add getPort to resolve Port(0) #17559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timotheecour
force-pushed
the
pr_getPort
branch
from
518c1e0 to
25ebe47
Compare
timotheecour
added
the
TODO: followup needed
timotheecour
force-pushed
the
pr_getPort
branch
from
25ebe47 to
4315108
Compare
ghost
reviewed
Mar 28, 2021
timotheecour
removed
the
TODO: followup needed
dom96
requested changes
Mar 29, 2021
lib/pure/asynchttpserver.nim
Outdated
Comment on lines
89
to
99
| func getSocket*(self: AsyncHttpServer): AsyncSocket {.since: (1, 5, 1).} = | ||
| ## Field accessor. | ||
| runnableExamples: | ||
| from std/asyncdispatch import Port | ||
| from std/asyncnet import getFd | ||
| from std/nativesockets import getLocalAddr, AF_INET | ||
| let server = newAsyncHttpServer() | ||
| server.listen(Port(0)) # Socket is not bound until this point | ||
| let port = getLocalAddr(server.getSocket.getFd, AF_INET)[1] | ||
| doAssert uint16(port) > 0 | ||
| # note: a more direct way to get the port is `getPort`. | ||
| let (laddr, port) = getLocalAddr(server.getSocket.getFd, AF_INET) | ||
| assert uint16(port) > 0 | ||
| assert laddr == "0.0.0.0" | ||
| server.close() | ||
| a.socket | ||
| self.socket |
There was a problem hiding this comment.
It seems like there isn't much reason to keep this now that we have getPort, I don't see another reason why it would be useful. Since it was introduced in the same version it shouldn't cause breakage, can we remove it in this PR?
There was a problem hiding this comment.
maybe but it belongs in a separate PR, I've added a future work item to address this. getPort doesn't subsume getSocket, so that should be discussed separately. eg, it shows you can use this to get assert laddr == "0.0.0.0" in this example and there may be other use cases for getSocket.
There was a problem hiding this comment.
Argh, I don't see a reason not to do this in the same PR. But here you go: #17587
timotheecour
added
the
TODO: followup needed
Araq
reviewed
Mar 30, 2021
timotheecour
force-pushed
the
pr_getPort
branch
from
2bde084 to
c2c97c8
Compare
|
PTAL |
timotheecour
removed
the
TODO: followup needed
This was referenced Apr 17, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I also updated the module-level example to promote best practices and avoid issues like
Address already in usecaused by hard coded ports as explained in #14327future work
getSocketnow that we havegetPort=> Removes asynchttpserver.getSocket. #17587